search

digitalfabrik / entitlementcard

App for 'Digitale Berechtigungskarten', generally benefit card for volunteers or socially vulnerable groups in Germany. App for Android & iOS + Backend + Administration Web Portal – 100% Open Source.
MIT License
36 stars 3 forks source link

If a favorite store has been changed, it will no longer be available in favorites #1493

Open seluianova opened 4 months ago

seluianova commented 4 months ago

Follow up to https://github.com/digitalfabrik/entitlementcard/issues/1214

Is your feature request related to a problem? Please describe. Because of the current implementation of data import, when we change any attributes of the acceptance store, we delete the old record in the database and create a new one with a new ID. As a side effect, if a modified store has been saved as a favorite on some device, it will appear as "No longer available" to the user. The user will have to delete it from favorites and save it again.

Describe the solution you'd like Would be nice to get constant acceptance store ids from the upstream, instead of generating them on our side.

Describe alternatives you've considered Perhaps we could treat some of the store attributes as constant (like name and coordinates?) and use them to compare data during the import.

Additional context Add any other context or screenshots about the feature request here.

f1sh1918 commented 4 months ago

@seluianova i think this should be prio high, or we should disable the favorites by a feature flag until we fixed that. Should be discussed in the next weekly