search

digitalfabrik / entitlementcard

App for 'Digitale Berechtigungskarten', generally benefit card for volunteers or socially vulnerable groups in Germany. App for Android & iOS + Backend + Administration Web Portal – 100% Open Source.
MIT License
36 stars 3 forks source link

Fix missing metadata for ios promotion #1543

Open f1sh1918 opened 2 months ago

f1sh1918 commented 2 months ago

Is your feature request related to a problem? Please describe. For the promotion of the current ios app version some meta data is missing. Looks like the whats new wasn't provided anymore

Describe the solution you'd like

Additional context Add any other context or screenshots about the feature request here.

f1sh1918 commented 2 months ago

@ztefanie maybe my issue since i restructured the metadata here https://github.com/digitalfabrik/entitlementcard/pull/1503 But not sure why "whats new" was deleted in the store I wonder whether we need release notes in the metadata since they are static in the moment and i think we could just delete them and maintain in the store or set skip_metadata in fastlane, since its false in moment from testflight to production.

f1sh1918 commented 3 weeks ago

Unfortunately the issue still exists https://app.circleci.com/pipelines/github/digitalfabrik/entitlementcard/6250/workflows/68924037-acd2-443b-8231-e7b6bbb628c4/jobs/44369

ztefanie commented 2 weeks ago

I think the path is set wrongly. My first thougths are: maybe the path is wrong, maybe this will work: "metadata_path: ./fastlane/#{build_config_name}/metadata or it is because nuernberg is also available in english and therefore english release notes are mandatory As we agrred to have all the metadata in the repo (like screeshots) it makes sense to fix this issue. I would prefer to also have the release notes in the repo, but I am also fine if you move it, but the metadata-folder structure should be fixed anyways especially because of the screenshots

steffenkleinle commented 2 weeks ago

I think the path is set wrongly. My first thougths are: maybe the path is wrong, maybe this will work: "metadata_path: ./fastlane/#{build_config_name}/metadata

Yes, that would be my guess, too. In integreat we use the path: ./ios/fastlane/#{build_config_name}/metadata. Accordingly, the path here should probably be: ./ios/fastlane/#{build_config_name}/metadata.

or it is because nuernberg is also available in english and therefore english release notes are mandatory.

Seems not to be the case, checked in AppStoreConnect, app is only available in German.

f1sh1918 commented 1 day ago

alright. thx for all your help :) I think steffi is right, since we have two fastlane files (android & ios) and do not execute it from the parent path like in integreat