search

digitalfabrik / entitlementcard

App for 'Digitale Berechtigungskarten', generally benefit card for volunteers or socially vulnerable groups in Germany. App for Android & iOS + Backend + Administration Web Portal – 100% Open Source.
MIT License
37 stars 3 forks source link

NPM workspaces installing dependencies incorrectly #1659

Open steffenkleinle opened 2 months ago

steffenkleinle commented 2 months ago

Is your feature request related to a problem? Please describe. We have two npm workspaces: administration and frontend/buildConfigs. Since the frontend/buildConfigs workspace has only a dependency to typescript, only this package and its subdependencies should be installed in the root. However, a lot of other dependencies are installed in the root as well, seemingly arbitrarily.

Describe the solution you'd like Clean up the dependencies and/or figure out why this happens. The dependencies should be installed correctly.

For example, the eslint plugin for jest fails to detect the version of jest since one is installed in the root and one in administration. This should be fixed (remove setting the version manually in .eslintrc.js).

Describe alternatives you've considered Ignore it.

Additional context Mattermost discussion: https://chat.tuerantuer.org/digitalfabrik/pl/8zmj3gaombrgtb1jqpspbpctzy

f1sh1918 commented 1 month ago

I wouldn't put that much effort in that but switch to a yarn monorepo and add there a general config package. If we can generate a yml file from typescript as we already do in the frontend package we could also generate the backend/config.yml