digitalfabrik / entitlementcard

App for 'Digitale Berechtigungskarten', generally benefit card for volunteers or socially vulnerable groups in Germany. App for Android & iOS + Backend + Administration Web Portal – 100% Open Source.
MIT License
36 stars 3 forks source link

(IT Infrastructure) Shutdown or recreate nominatim instance #440

Closed maxammann closed 1 year ago

maxammann commented 2 years ago

The current nominatim instance is just a hack. We need to recreate it or delete it if not used.

Change the protocol to HTTPS in the backend.

maxammann commented 2 years ago

@klinzo I created this so we do not forget

steffenkleinle commented 2 years ago

This is also relevant for deciding on an expiration date for the geocoding cache: https://github.com/digitalfabrik/ehrenamtskarte/pull/439#discussion_r780224454

steffenkleinle commented 2 years ago

In photon it is not possible to search for postal codes or restrict the search data to a specific country without additional configuration. I am not sure how easy it is to configure it accordingly but without it we'd need to change the whole geocoding logic as the current way won't work anymore. Example postal code search: https://photon.komoot.io/api?q=86161

https://github.com/komoot/photon#customized-search-data

If you need search data in other languages or restricted to a country you will need to create your search data by your own. Once you have your Nominatim database ready, you can import the data to photon.

maxammann commented 2 years ago

In photon it is not possible to search for postal codes or restrict the search data to a specific country without additional configuration. I am not sure how easy it is to configure it accordingly but without it we'd need to change the whole geocoding logic as the current way won't work anymore. Example postal code search: https://photon.komoot.io/api?q=86161

https://github.com/komoot/photon#customized-search-data

If you need search data in other languages or restricted to a country you will need to create your search data by your own. Once you have your Nominatim database ready, you can import the data to photon.

Alright :D then lets stick to nominatim. We could just makr our artifacts public and let others benefit from our processing power :)

steffenkleinle commented 2 years ago

Alright :D then lets stick to nominatim. We could just makr our artifacts public and let others benefit from our processing power :)

Is it feasible to keep nominatim up to date/maintain it? You mentioned this was too much effort.

maxammann commented 2 years ago

I mean it is a lot of work and maintanance, but if it has to be done :D

steffenkleinle commented 2 years ago

I'll try to come up with another solution :)

maxammann commented 2 years ago

The thing is we already have to generate the maps once per year. I could reuse the setup for nominatin

The only thing is that we need to keep up with nominatim breaking changes. But this is probably not a huge problem.

maxammann commented 2 years ago

high-priority: Should be done before I forget about the nominatim creation :D

maxammann commented 2 years ago

We should probably add basic auth for now, at least before this project gets more attention.

f1sh1918 commented 1 year ago

will be fixed with #442