Add ID by calculating hash of card details in the app

digitalfabrik / entitlementcard

App for 'Digitale Berechtigungskarten', generally benefit card for volunteers or socially vulnerable groups in Germany. App for Android & iOS + Backend + Administration Web Portal – 100% Open Source.

MIT License

35 stars 3 forks source link

Add ID by calculating hash of card details in the app #602

Open maxammann opened 1 year ago

maxammann commented 1 year ago

As a user I to see a "string" which identifies my card. This string should be transmittable via telephone for example to our technical support team.

Acceptance Criteria:

[ ] Add a button that opens a dialog for additional information.
[ ] There the last 8 characters of the cardInfoHash should be printed.

Design

f1sh1918 commented 4 months ago

This is a good idea. I just think the last 5 chars should be good enough. No one will transmit the complete has xxxx-426e-7834

But actually it makes it more difficult to identify the card, because the hash

michael-markl commented 4 months ago

For "human" transmission, base64 is not really optimal as there are a lot of similar characters in the alphabet (plus it's case sensitive). Maybe a base32 code would fit better here (not case sensitive, and no similar characters such as O and 0 etc.) 🤔 But base64 should probably be fine too if we don't want to introduce another encoding... (... especially as we already print the base64 hash on the PDF I think)