search

digitalfabrik / entitlementcard

App for 'Digitale Berechtigungskarten', generally benefit card for volunteers or socially vulnerable groups in Germany. App for Android & iOS + Backend + Administration Web Portal – 100% Open Source.
MIT License
35 stars 3 forks source link

[Application] Make the application a standalone app #626

Open michael-markl opened 1 year ago

michael-markl commented 1 year ago

Extract the ApplyController.tsx into a standalone app. The result should be a

maxammann commented 1 year ago

I set this to low-prio because we can also resolve that after release.

In worst case we will have to do a redirect to a different domain if we move the application for forms.

f1sh1918 commented 8 months ago

@michael-markl why do we need this and why is it in HighPrio after Release?

michael-markl commented 8 months ago

It is suboptimal to serve >2MB of javascript just for an application form.

f1sh1918 commented 2 months ago

Hm the main.js 2,2MB. don't you think we could start with route based code splitting. I really dunno how much effort this is to create a standalone app. But i don't expect the bundle size to be less than the half. And i really question if its worth to do that

michael-markl commented 2 months ago

I do think that less than half of the JS (and probably half of the CSS) in the bundle is used in the application form. But yes, maybe it would be less complex to start with route based code splitting.

maxammann commented 2 months ago

Isn't 2MB still very little to today's standards? :/

michael-markl commented 2 months ago

For shipping an application form without much interactivity I'd say it's a lot of JS :D If it was a video game, I'd be fine :D (I am not saying this is a high prio task :D )

f1sh1918 commented 2 months ago

created task for code splitting https://github.com/digitalfabrik/entitlementcard/issues/1395