search

diondokter / at-commands

Rust project for building and parsing at commands
Apache License 2.0
33 stars 5 forks source link

Change from &str to AsRef<[u8]> in builder #10

Closed aria-aghaei closed 1 year ago

aria-aghaei commented 1 year ago

Changes from &str to AsRef in the CommandBuilder. For #8

Let me know if you want me to add a test case or have suggestions.

diondokter commented 1 year ago

Hey there, thanks for the PR!

Could you add this change to the changelog? Just add a new "unreleased" header to the list and out this under there.

Are you in a hurry to get this released on crates io? I'll release a new version on crates.io once this is merged.

aria-aghaei commented 1 year ago

Sure, I can add it to the changelog. I'm not in a hurry, you can merge whenever

diondokter commented 1 year ago

Thanks!

diondokter commented 1 year ago

Now released as 0.5.4