search

diondokter / at-commands

Rust project for building and parsing at commands
Apache License 2.0
33 stars 5 forks source link

Add support for adding an unformatted raw parameter #13

Closed lulf closed 2 months ago

lulf commented 2 months ago

This allows passing i.e. configuration data directly from network or flash without needing to parse or transform it, such as a pin number which is more a 'series of digits' than an integer.

diondokter commented 2 months ago

I don't have problems with this. Would you like me to release it?

Also, that new unused feature detection comes in handy again!

lulf commented 2 months ago

I don't have problems with this. Would you like me to release it?

If you don't mind, that would be much appreciated, as I have an upcoming PR to embassy using this.

diondokter commented 2 months ago

Done, released as 0.5.5 Apparently this crate has a yearly release schedule now :P Third time in a row there's one release in september lol

Interesting! What part of Embassy is gonna use it? The nRF91 net?

lulf commented 2 months ago

@diondokter Originally for this PR https://github.com/embassy-rs/embassy/pull/3376 - turns out I misread the documentation, the pin is quoted after all according to https://docs.nordicsemi.com/bundle/ref_at_commands/page/REF/at_commands/security/cpin_set.html :facepalm: I think I looked at some unofficial code that didn't quote it or something. Apologies for spending your time on it!

diondokter commented 2 months ago

Oh hahaha, well the function is a fine addition to the crate!