search

discord-tickets / bot

The most popular open-source and self-hosted ticket management bot for Discord - a free alternative to the premium and white-label plans of other popular ticketing bots.
https://discordtickets.app
GNU General Public License v3.0
880 stars 459 forks source link

`/new` with invalid `references` value causes unexpected error #540

Open eartharoid opened 3 months ago

eartharoid commented 3 months ago

because this line doesn't check if the referenced ticket exists https://github.com/discord-tickets/bot/blob/22e26e11d96321ca66deaf2d8cc60c2c2b54f75b/src/lib/tickets/manager.js#L635

which happens earlier but is out of scope https://github.com/discord-tickets/bot/blob/22e26e11d96321ca66deaf2d8cc60c2c2b54f75b/src/lib/tickets/manager.js#L589-L590