Chart enhancements + stub of `places` and `districtingProblems`

mariogiampieri commented 1 week ago

Description

Chart behavior based on MapDocument properties, including a target number of districts (manually set for now) and a total population. This chart behavior includes:
- an ideal population per zone indicated as a vertical labelled line
- the chart x-max set based on ideal pop * 2 or dataMax, whichever is larger (i.e. if someone is going overboard the chart will follow
- separately, setting the # of colors in the palette to equal the target # of districts.

Re: places and problems, to circle back on:

Create draft DistrictrPlace and DistrictrProblem models, following v1 places / problems and syntax that a user selects to start a session. This was in service of getting the proper target # districts for each map. I suspect that we'll want to discuss and revise how these objects fit in with our data model. For now at least, they provide a target for each test map, based on districtr v1 statewide places and problems
Per the above, utility scripts (still WIP) to load data from districtr v1 into these new tables. Again, we should discuss where these things should live long term (holding for a later branch)

Reviewers

Primary:
Secondary:

Checklist

[ ] Added/Updated related documentation (if applicable).
[ ] Added/Updated related unit tests (if applicable).

Screenshots (if applicable):

raphaellaude commented 1 week ago

I know you didn't want a review yet but I had a few big comments I thought would be better to discuss sooner than later

PS. Nice work. The chart looks super awesome, too.

mariogiampieri commented 1 week ago

I know you didn't want a review yet but I had a few big comments I thought would be better to discuss sooner than later

PS. Nice work. The chart looks super awesome, too.

TY and agree with all your points! I will respond to each in kind, but for now, the PR app does have a draft bar chart that's more sensible: https://districtr-v2-167-app.fly.dev/

mariogiampieri commented 1 week ago

Ok, the chart is working as intended now, with a pin put in the places and problems. The num_districts can be manually set for now for the chart to behave properly.

districtr / districtr-v2