search

divvun / libdivvun

lib for running gramcheck and other pipelines + cli; modules for CG→spelling, CG→feedback, tagging blanks
https://giellalt.github.io/proof/gramcheck/GrammarCheckerDocumentation.html
GNU General Public License v3.0
9 stars 1 forks source link

Hidden dependency: libarchive #9

Closed TinoDidriksen closed 6 years ago

TinoDidriksen commented 6 years ago

./configure --enable-checker --enable-cgspell --enable-python-bindings ran fine, but the build said:

In file included from checker.cpp:19:
In file included from ./pipeline.hpp:29:
./pipespec.hpp:50:10: fatal error: 'archive.h' file not found

configure needs to check for a usable libarchive.

unhammer commented 6 years ago

Hm, I did try to check ( https://github.com/divvun/libdivvun/blob/master/configure.ac#L108 and https://github.com/divvun/libdivvun/blob/master/configure.ac#L88 ). m4 strikes again.

TinoDidriksen commented 6 years ago

Ah, what probably happened then is that it saw libarchive from Macports but for whatever reason didn't get the -I passed along.

unhammer commented 6 years ago

Do you know which goal it was building when that happened? I see the Makefile.am only mentions libarchive for divvun-gen-sh, but I guess it should mention that elsewhere too.

divvun_gen_sh_LDADD    = $(PUGIXML_LIBS)   $(LIBARCHIVE_LIBS)
divvun_gen_sh_CXXFLAGS = $(PUGIXML_CFLAGS) $(LIBARCHIVE_CFLAGS)
unhammer commented 6 years ago

Was this fixed by #11 ?

TinoDidriksen commented 6 years ago

Hm, I guess that must have been the core problem. So yeah, fixed in https://github.com/divvun/libdivvun/commit/51aceee490ddf0f005df8295dcf1c73e7ca31a5f