djstevenson / songs-to-the-siren

A blog about songs
MIT License
0 stars 0 forks source link

Logged-in user should see own moderated comments #208

Closed djstevenson closed 4 years ago

djstevenson commented 4 years ago

What I did

I logged in as a non-admin user, viewed a song, and added a comment

What happened

The song view was refreshed, but I couldn't see the new comment. The "flash" at the top says that it is being moderated, but this still seems odd behaviour.

What should have happened

Although no-one else should see my comment until it has been modded, I should see my own comments. It should obviously be flagged up that it awaits moderation.

djstevenson commented 4 years ago

What about deleted comments? Might be best to leave them in the DB with a 'deleted' flag, and then we can show them as deleted to the user. But then, if people are posting stuff we need to delete, do we care that much about helping them? Let's leave this until a possible later version.

djstevenson commented 4 years ago

The issue raised in this ticket was fixed in #224 Will raise separate ticket about possibly flagging up deletes. An alternative is to send email notifications.