search

djstevenson / songs-to-the-siren

A blog about songs
MIT License
0 stars 0 forks source link

Need a proper 404 page #287

Closed djstevenson closed 4 years ago

djstevenson commented 4 years ago

I just realised I'm still using the default Mojolicious 404 page.

Should probably check other error pages too (e.g. ensure nothing sensitive is leaked when an exception is thrown). Maybe make a test end-point that exists just to call 'die'.

djstevenson commented 4 years ago

Would be nice to go to something like a song page for U2's "I still haven't found what I'm looking for", but that is slightly complex - I'd have to put the song in the DB, have it hidden except when showing the error page.

Also, for other exceptions, maybe Buzzcock's Something's Gone Wrong Again.

For now, maybe just error pages with those songs embedded.

djstevenson commented 4 years ago

Fixed by PR #290

Basically, I added a "content' page that embeds the aforementioned songs.