search

dkniffin / active_material

ActiveAdmin skin based on Google's Material Design
MIT License
177 stars 69 forks source link

Header scope #44

Closed irmela closed 6 years ago

irmela commented 6 years ago

As part of app/assets/stylesheets/active_material/components/header.scss we include toolbar styling for .header. This leads to problems for example when there are other elements with a header class (in my case a table header). What do you think about applying the styling to #header instead of .header?

Current

.header {
  @include am-toolbar;
  @include am-toolbar-primary;
  padding-right: am-unit(8);
}

Improved

#header {
  @include am-toolbar;
  @include am-toolbar-primary;
  padding-right: am-unit(8);
}