search

dkniffin / active_material

ActiveAdmin skin based on Google's Material Design
MIT License
177 stars 69 forks source link

Remove connection to Google servers #68

Closed irmela closed 2 years ago

irmela commented 4 years ago

This PR fixes #48 and removes the am-web-font mixin because I think it was only used to have a fallback font in case Webfont.js font loader was not active. Please let me know if this is not a good way of including the font.

irmela commented 4 years ago

@cwmanning thanks for the suggestion. I updated the PR to use RobotoDraft instead.

dkniffin commented 3 years ago

@irmela I've taken over as maintainer of this repo and I'm reviewing open issues and PRs. This seems like a good change, but can you briefly explain what this change means for end-users? Do they have to self-host the font files now? If so, are they accessible somewhere for download? Could we include those font-files in this gem?

irmela commented 3 years ago

Hi @dkniffin thanks for taking over this repo as maintainer.

can you briefly explain what this change means for end-users?

With this change we will not access Google servers anymore to load the font. The font is now included as part of this gem and implemented via @font-face.