Closed highsource closed 6 years ago
Merging #54 into master will increase coverage by
0.04%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #54 +/- ##
============================================
+ Coverage 75.99% 76.04% +0.04%
Complexity 1321 1321
============================================
Files 101 101
Lines 4629 4633 +4
Branches 801 801
============================================
+ Hits 3518 3523 +5
+ Misses 895 894 -1
Partials 216 216
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
.../jwktl/parser/de/components/DEWordFormHandler.java | 78.06% <100%> (+0.58%) |
72 <18> (-1) |
:arrow_down: |
...tl/parser/de/components/DEPartOfSpeechHandler.java | 69.11% <0%> (+1.47%) |
16% <0%> (+1%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update db23009...f972a2e. Read the comment docs.
CLA not signed yet.
I've asked for a confirmation for CCLA, but this may take my employer very long time (huge corp). Should I maybe sign the ICLA first?
Thanks for all your changes. ICLA would be fine for merging. CCLA is recommended, but it depends on what status the work has for your company and how they deal with OSS projects in general.
I'm working to get CCLA but it may take pretty long time.
I've signed and e-mailed the ICLA.
Could this please be merged as well?
This fixes #50 by adding label.endsWith("*") check. Unit test is also included using the word Gelb.