search

dkpro / dkpro-jwktl

Java Wiktionary Library
http://dkpro.org/dkpro-jwktl/
Apache License 2.0
57 stars 26 forks source link

#60 Exception parsing invalid translation template #61

Closed highsource closed 6 years ago

highsource commented 6 years ago

This is a WIP PR, please do not merge yet.

codecov-io commented 6 years ago

Codecov Report

Merging #61 into master will increase coverage by 0.03%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #61      +/-   ##
============================================
+ Coverage     75.99%   76.03%   +0.03%     
- Complexity     1321     1323       +2     
============================================
  Files           101      101              
  Lines          4629     4631       +2     
  Branches        801      802       +1     
============================================
+ Hits           3518     3521       +3     
  Misses          895      895              
+ Partials        216      215       -1
Impacted Files Coverage Δ Complexity Δ
...ktl/parser/de/components/DETranslationHandler.java 90.37% <100%> (+0.89%) 48 <0> (+2) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update db23009...245fc2d. Read the comment docs.

highsource commented 6 years ago

Work done, this can be (please) merged.

highsource commented 6 years ago

@chmeyer Thank you for the review, I've fixed both points.