search

dlr-eoc / prosEO

prosEO – A Processing System for Earth Observation Data
GNU General Public License v3.0
14 stars 1 forks source link

[prosEO CLI] Orbit show + range enhancement #112

Closed dlr-tangosierra closed 1 year ago

dlr-tangosierra commented 3 years ago

prosEO version 0.5.2 Windows 10

Context: When the user is trying to show orbits for a given orbit range and the value of [from] is bigger than the value of [to] the system returns an empty value. While technically correct, it would be a good idea to return an error message that the input was incorrect and that the system should instead use correct lower and upper bounds.

Problematic example: prosEO (NM4T)> orbit show --from=3003 --to=1234 NM4T_Spacecraft_1 --- []

tangobravo62 commented 3 years ago

This behaviour is consistent throughout the CLI. However, the messages have been improved somewhat:

prosEO (PTM)> orbit show --from=3007 --to=3001 PTS
(E2852) No orbits found for given search criteria
prosEO (PTM)> 
prosEO (PTM)> order show --from=2020-12-31 --to=2020-01-01
(E2930) No orders found for given search criteria

Since the CLI aims at proficient users, it is suggested to leave the behaviour as is.

tangobravo62 commented 1 year ago

No further optimization required.