dlr-eoc / prosEO

prosEO – A Processing System for Earth Observation Data
GNU General Public License v3.0
14 stars 1 forks source link

[prosEO CLI]orbit show range - bug in from/to #113

Closed dlr-tangosierra closed 3 years ago

dlr-tangosierra commented 3 years ago

prosEO version 0.5.2 Windows 10

Context: When the user is trying to show a range or orbits and uses only [from] or [to], the system retrieves all the orbits. This is a bug.

Proposition: Return an error message requiring both from and to.

Problematic example 1

prosEO (NM4T)> orbit show --from=3003 NM4T_Spacecraft_1
- id: 8072
  version: 1
  missionCode: "NM4T"
  spacecraftCode: "NM4T_Spacecraft_1"
  orbitNumber: 1236
  startTime: "2020-09-01T16:02:00.000000"
  stopTime: "2020-09-01T18:02:00.000000"
- id: 8068
  version: 2
  missionCode: "NM4T"
  spacecraftCode: "NM4T_Spacecraft_1"
  orbitNumber: 1234
  startTime: "2020-09-01T12:00:00.000000"
  stopTime: "2020-09-01T14:00:01.123400"
- id: 8083
  version: 1
  missionCode: "NM4T"
  spacecraftCode: "NM4T_Spacecraft_1"
  orbitNumber: 2000
  startTime: "2020-09-10T16:02:00.000000"
  stopTime: "2020-09-11T16:02:00.000000"
- id: 8084
  version: 1
  missionCode: "NM4T"
  spacecraftCode: "NM4T_Spacecraft_1"
  orbitNumber: 3000
  startTime: "2019-11-04T09:00:00.200000"
  stopTime: "2019-11-04T10:41:10.300000"
- id: 8085
  version: 1
  missionCode: "NM4T"
  spacecraftCode: "NM4T_Spacecraft_1"
  orbitNumber: 3001
  startTime: "2019-11-04T10:41:10.300000"
  stopTime: "2019-11-04T12:22:20.400000"
- id: 8086
  version: 1
  missionCode: "NM4T"
  spacecraftCode: "NM4T_Spacecraft_1"
  orbitNumber: 3002
  startTime: "2019-11-04T12:22:20.400000"
  stopTime: "2019-11-04T14:03:30.500000"
- id: 8087
  version: 1
  missionCode: "NM4T"
  spacecraftCode: "NM4T_Spacecraft_1"
  orbitNumber: 3003
  startTime: "2019-11-04T14:03:30.500000"
  stopTime: "2019-11-04T15:44:40.600000"
- id: 8088
  version: 1
  missionCode: "NM4T"
  spacecraftCode: "NM4T_Spacecraft_1"
  orbitNumber: 3004
  startTime: "2019-11-04T15:44:40.600000"
  stopTime: "2019-11-04T17:25:50.700000"

problematic example 2

prosEO (NM4T)> orbit show --to=3003 NM4T_Spacecraft_1
- id: 8072
  version: 1
  missionCode: "NM4T"
  spacecraftCode: "NM4T_Spacecraft_1"
  orbitNumber: 1236
  startTime: "2020-09-01T16:02:00.000000"
  stopTime: "2020-09-01T18:02:00.000000"
- id: 8068
  version: 2
  missionCode: "NM4T"
  spacecraftCode: "NM4T_Spacecraft_1"
  orbitNumber: 1234
  startTime: "2020-09-01T12:00:00.000000"
  stopTime: "2020-09-01T14:00:01.123400"
- id: 8083
  version: 1
  missionCode: "NM4T"
  spacecraftCode: "NM4T_Spacecraft_1"
  orbitNumber: 2000
  startTime: "2020-09-10T16:02:00.000000"
  stopTime: "2020-09-11T16:02:00.000000"
- id: 8084
  version: 1
  missionCode: "NM4T"
  spacecraftCode: "NM4T_Spacecraft_1"
  orbitNumber: 3000
  startTime: "2019-11-04T09:00:00.200000"
  stopTime: "2019-11-04T10:41:10.300000"
- id: 8085
  version: 1
  missionCode: "NM4T"
  spacecraftCode: "NM4T_Spacecraft_1"
  orbitNumber: 3001
  startTime: "2019-11-04T10:41:10.300000"
  stopTime: "2019-11-04T12:22:20.400000"
- id: 8086
  version: 1
  missionCode: "NM4T"
  spacecraftCode: "NM4T_Spacecraft_1"
  orbitNumber: 3002
  startTime: "2019-11-04T12:22:20.400000"
  stopTime: "2019-11-04T14:03:30.500000"
- id: 8087
  version: 1
  missionCode: "NM4T"
  spacecraftCode: "NM4T_Spacecraft_1"
  orbitNumber: 3003
  startTime: "2019-11-04T14:03:30.500000"
  stopTime: "2019-11-04T15:44:40.600000"
- id: 8088
  version: 1
  missionCode: "NM4T"
  spacecraftCode: "NM4T_Spacecraft_1"
  orbitNumber: 3004
  startTime: "2019-11-04T15:44:40.600000"
  stopTime: "2019-11-04T17:25:50.700000"
tangobravo62 commented 3 years ago

Fixed:

prosEO (PTM)> orbit show PTS
S/C    Orb-# Sensing Start              Sensing Stop              
PTS    03000 2019-11-04T09:00:00.200000 2019-11-04T10:41:10.300000
PTS    03001 2019-11-04T10:41:10.300000 2019-11-04T12:22:20.400000
PTS    03002 2019-11-04T12:22:20.400000 2019-11-04T14:03:30.500000
PTS    03003 2019-11-04T14:03:30.500000 2019-11-04T15:44:40.600000
PTS    03004 2019-11-04T15:44:40.600000 2019-11-04T17:25:50.700000
PTS    03005 2019-11-04T17:25:50.700000 2019-11-04T19:07:00.800000

prosEO (PTM)> orbit show --from=3004 PTS
S/C    Orb-# Sensing Start              Sensing Stop              
PTS    03004 2019-11-04T15:44:40.600000 2019-11-04T17:25:50.700000
PTS    03005 2019-11-04T17:25:50.700000 2019-11-04T19:07:00.800000

prosEO (PTM)> orbit show --to=3001 PTS
S/C    Orb-# Sensing Start              Sensing Stop              
PTS    03000 2019-11-04T09:00:00.200000 2019-11-04T10:41:10.300000
PTS    03001 2019-11-04T10:41:10.300000 2019-11-04T12:22:20.400000

prosEO (PTM)> orbit show --from=3001 --to=3001 PTS
S/C    Orb-# Sensing Start              Sensing Stop              
PTS    03001 2019-11-04T10:41:10.300000 2019-11-04T12:22:20.400000