dlr-eoc / prosEO

prosEO – A Processing System for Earth Observation Data
GNU General Public License v3.0
14 stars 1 forks source link

Build process: Building a module does not fail if Docker build fails #175

Closed tangobravo62 closed 1 year ago

tangobravo62 commented 1 year ago

When building a module (or prosEO as a whole) the build process does not detect failures of the Docker build ant task. Expected behaviour is to fail whenever the Docker build fails.

tangobravo62 commented 1 year ago

Fixed by adding failonerror="true" to all POM files containing Ant tasks. Result example:

[INFO] --- maven-antrun-plugin:1.8:run (default) @ s1-mpl-monitor ---
[INFO] Executing tasks

main:
     [exec] [2023-01-23T10:43:46.110097000Z][docker-credential-desktop][F] get system info: exec: "sh": executable file not found in $PATH
     [exec] [goroutine 1 [running, locked to thread]:
     [exec] [common/pkg/system.init.0()
     [exec] [   common/pkg/system/os_info.go:32 +0x1bc
     [exec] Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  15.614 s
[INFO] Finished at: 2023-01-23T11:43:46+01:00
[INFO] ------------------------------------------------------------------------