search

dlr-gtlab / intelligraph-module

A Node-based Workflow Engine for GTlab
1 stars 0 forks source link

Revisit input nodes and remove redundant implementations #80

Open rainman110 opened 7 months ago

rainman110 commented 7 months ago

In GitLab by @mariusalexander on Apr 3, 2024, 15:57

For instance the logic source node is doubled. In addition the number source node is doubled as well. These redundant implementations should be merged.

Todo:

rainman110 commented 5 months ago

In GitLab by @mariusalexander on May 17, 2024, 13:53

We have the following input nodes. Is it correct that you @jensschmeink would like to remove the following nodes (and keep the others next to it?)

In addition, I am wondering whether we really need separate integer and double nodes, since the only difference is that one increments in fixed intervals. It might be cumbersome for the user to differentiate between int and double nodes (since these cant be interconnected either currently). Maybe we could implement a "step size" attribute for the double input.

grafik

rainman110 commented 5 months ago

In GitLab by @jensschmeink on May 17, 2024, 14:00

The input nodes are also meant to be the connection to the property world of the datamodel. Therefore it is the idea to have corresponding nodes for each property type

rainman110 commented 5 months ago

In GitLab by @mariusalexander on May 17, 2024, 14:08

I know, but maybe we do not need that granularity in IntelliGraph. It should be possible feed int-properties with double input nodes and vice versa. Maybe we could discuss this with the others? I do not know how KNIME handles this, but AFAIK Blender does not have a specific "integer" node or data type (then again its use case is entirely different).

rainman110 commented 5 months ago

In GitLab by @jensschmeink on May 21, 2024, 12:55

Another point (but I think no show stopper) are the different data types that are defined for the outport

rainman110 commented 5 months ago

In GitLab by @mariusalexander on May 23, 2024, 09:06

I have noticed there is also the Object Input and Object Source node. Is there any difference/which should I keep? @jensschmeink

rainman110 commented 5 months ago

In GitLab by @jensschmeink on May 23, 2024, 09:28

The Object input has the same interface as the other input related nodes and should be prefered I think

rainman110 commented 3 months ago

In GitLab by @mariusalexander on Jul 22, 2024, 14:27

Removed StringListData and StringListInputNode in commit dfdc05b818e21374924ca1d885d39411120b0bad