dlvhdr / gh-dash

A beautiful CLI dashboard for GitHub 🚀

https://dlvhdr.github.io/gh-dash

MIT License

6.82k stars 195 forks source link

feat(ui): update the PR view diff changes summary #295

Closed Sanix-Darker closed 11 months ago

Sanix-Darker commented 1 year ago

Summary

UI changes proposal on +/- with colors like the view we have on github.

[x] update colors (green/red) for adds/deletions.
[x] add a formater util function for killos /Millions changes diffs.
[x] add a sync amount of spaces between adds and deletions.

How did you test this change?

On my Ubuntu Os 20.04 , tmux, under allacrity.

go run gh-dash.go --debug

Images/Videos

BEFORE

Screenshot from 2023-07-22 19-19-04

AFTER

Screenshot from 2023-07-22 19-09-07

NOTE

This should work for all Unix based system.
I didn't create an issue because i thought there were not too many things to do on this branch, I hope it's okay.

dlvhdr commented 11 months ago

@Sanix-Darker I fixed the issue, also see the open issue on lipgloss for reference: https://github.com/charmbracelet/lipgloss/issues/144

Sanix-Darker commented 11 months ago

looks amazing @dlvhdr , thank you so much !