dlvhdr / gh-dash

A beautiful CLI dashboard for GitHub 🚀
https://dlvhdr.github.io/gh-dash
MIT License
6.82k stars 195 forks source link

[BUG] version 3.10.0 - `m` hotkey doesn't do anything #300

Closed drupol closed 11 months ago

drupol commented 11 months ago

I just upgraded to version 3.10.0 and the m hotkey (merge) doesn't work anymore.

With version 3.9.0, it used to work correctly, I had a menu in the bottom left. In 3.10.0, absolutely nothing is happening.

debug.log ```shell ❯ cat debug.log -p 7:37PM DEBUG Logging to debug.log 7:37PM DEBUG Starting task id="fetching_prs_1_2023-08-01 19:37:50.623226005 +0200 CEST m=+0.010355536" 7:37PM DEBUG Starting task id="fetching_prs_2_2023-08-01 19:37:50.62334856 +0200 CEST m=+0.010478089" 7:37PM DEBUG Starting task id="fetching_prs_3_2023-08-01 19:37:50.623428067 +0200 CEST m=+0.010557596" 7:37PM DEBUG Starting task id="fetching_prs_4_2023-08-01 19:37:50.623499059 +0200 CEST m=+0.010628588" 7:37PM DEBUG Starting task id="fetching_prs_5_2023-08-01 19:37:50.623536333 +0200 CEST m=+0.010665863" 7:37PM DEBUG Starting task id="fetching_prs_6_2023-08-01 19:37:50.623580935 +0200 CEST m=+0.010710463" 7:37PM DEBUG Starting task id="fetching_prs_7_2023-08-01 19:37:50.623629818 +0200 CEST m=+0.010759348" 7:37PM DEBUG Fetching PRs query="repo:NixOS/nixpkgs is:open draft:false" limit=50 endCursor= 7:37PM DEBUG Fetching PRs query="repo:NixOS/nixpkgs is:open draft:false author:r-ryantm" limit=50 endCursor= 7:37PM DEBUG Fetching PRs query="is:open review-requested:@me" limit=50 endCursor= 7:37PM DEBUG Fetching PRs query="repo:NixOS/nixpkgs is:open draft:false label:\"12.approvals: 1\"" limit=50 endCursor= 7:37PM DEBUG Fetching PRs query="repo:NixOS/nixpkgs is:open draft:false label:\"12. first-time contribution\"" limit=50 endCursor= 7:37PM DEBUG Fetching PRs query="is:open author:@me" limit=50 endCursor= 7:37PM DEBUG Fetching PRs query="is:open involves:@me -author:@me" limit=50 endCursor= 7:37PM DEBUG Key pressed key=right 7:37PM DEBUG Key pressed key=right 7:37PM DEBUG Key pressed key=right 7:37PM DEBUG Key pressed key=right 7:37PM DEBUG Successfully fetched PRs query="is:open review-requested:@me" count=21 7:37PM DEBUG Task finished id="fetching_prs_6_2023-08-01 19:37:50.623580935 +0200 CEST m=+0.010710463" 7:37PM DEBUG Key pressed key=left 7:37PM DEBUG Successfully fetched PRs query="repo:NixOS/nixpkgs is:open draft:false author:r-ryantm" count=89 7:37PM DEBUG Task finished id="fetching_prs_4_2023-08-01 19:37:50.623499059 +0200 CEST m=+0.010628588" 7:37PM DEBUG Successfully fetched PRs query="is:open author:@me" count=32 7:37PM DEBUG Task finished id="fetching_prs_5_2023-08-01 19:37:50.623536333 +0200 CEST m=+0.010665863" 7:37PM DEBUG Successfully fetched PRs query="repo:NixOS/nixpkgs is:open draft:false" count=3218 7:37PM DEBUG Task finished id="fetching_prs_1_2023-08-01 19:37:50.623226005 +0200 CEST m=+0.010355536" 7:37PM DEBUG Successfully fetched PRs query="repo:NixOS/nixpkgs is:open draft:false label:\"12.approvals: 1\"" count=164 7:37PM DEBUG Task finished id="fetching_prs_3_2023-08-01 19:37:50.623428067 +0200 CEST m=+0.010557596" 7:37PM DEBUG Successfully fetched PRs query="repo:NixOS/nixpkgs is:open draft:false label:\"12. first-time contribution\"" count=309 7:37PM DEBUG Task finished id="fetching_prs_2_2023-08-01 19:37:50.62334856 +0200 CEST m=+0.010478089" 7:37PM DEBUG Successfully fetched PRs query="is:open involves:@me -author:@me" count=137 7:37PM DEBUG Task finished id="fetching_prs_7_2023-08-01 19:37:50.623629818 +0200 CEST m=+0.010759348" 7:38PM DEBUG Key pressed key=down 7:38PM DEBUG Key pressed key=down 7:38PM DEBUG Key pressed key=down 7:38PM DEBUG Key pressed key=m 7:38PM DEBUG Key pressed key=enter 7:38PM DEBUG Key pressed key=enter 7:38PM DEBUG Key pressed key=enter 7:38PM DEBUG Key pressed key=q ```
drupol commented 11 months ago

Found the issue, it seems that this is because of the color of the bottom bar.

I can see the confirmation step when I'm using a light terminal, not a dark terminal.

dlvhdr commented 11 months ago

Oh ok so i will need to fix that

drupol commented 11 months ago

The issue happen when using the Breeze color scheme.

See the issue in the screenshot:

image