search

dlvhdr / gh-dash

A beautiful CLI dashboard for GitHub 🚀
https://dlvhdr.github.io/gh-dash
MIT License
6.82k stars 195 forks source link

Remove `default_path` support in `repoPaths` configuration #345

Closed rmacklin closed 4 months ago

rmacklin commented 4 months ago

Summary

Now that we support the more general :owner/:repo template configuration (https://github.com/dlvhdr/gh-dash/pull/343), the prior default_path functionality (https://github.com/dlvhdr/gh-dash/pull/327) is redundant - e.g. this configuration:

default_path: ~/code/repos

can be achieved equivalently with:

:owner/:repo: ~/code/repos/:repo

Thus, we are removing the default_path syntax.

How did you test this change?

I updated the automated tests to show how the default_path test case is covered with the :owner/:repo syntax.

rmacklin commented 4 months ago

Heads up @markfeinstein @ushmz @Arinono since you are/were using default_path - in the next version of gh-dash you'll need to tweak your repoPaths configuration as in the example above.