dlvhdr / gh-dash

A beautiful CLI dashboard for GitHub 🚀

https://dlvhdr.github.io/gh-dash

MIT License

6.77k stars 191 forks source link

Add labels to PR sidebar. #369

Closed robdimsdale closed 1 month ago

robdimsdale commented 1 month ago

Summary

This PR adds support for labels in the PR sidebar, essentially identical to how they already render for issues.

I leverage PR labels a lot in my workflow, so this is helpful to quickly see which PRs have (or are missing) labels.

How did you test this change?

Add labels to PRs - see that they render similar to labels

Images/Videos

Here is an example PR with a label (PR can be found here).

dlvhdr commented 1 month ago

Looks good! Thank you

robdimsdale commented 1 month ago

Awesome - thanks for the quick merge!

dlvhdr commented 1 month ago

Hey @robdimsdale, just trying this feature out locally and noticed that if there are labels that overflow to the next line, things start to break. Can you please add code that checks if 2+ labels fit in the same line, and if not - overflow the label yourself by appending a new line?

Also can I suggest adding a margin of 1 line between label rows?

robdimsdale commented 1 month ago

@dlvhdr yeah, I just saw that too.

I'll take a look ASAP

robdimsdale commented 1 month ago

@dlvhdr fixed in: https://github.com/dlvhdr/gh-dash/pull/378