search

dmac / spin

Write RESTful web apps in Racket.
MIT License
229 stars 18 forks source link

Adding binary servlets #9

Closed stephengaito closed 2 years ago

stephengaito commented 8 years ago

Daniel,

This pull request adds in the binaryServlets.rkt module to provide get-file routes which will serve binary files.

I have also added a section to the README.md file detailing the two possible ways of serving binary files using the spin based routing.

This pull request is based upon my previous pull request: Adding multi segment route parameters #8 (which should probably be accepted first).

Again, let me know if there are any corrections you might want to be made to this pull request.

Regards, Stephen Gaito

dmac commented 8 years ago

I'll hold off on reviewing this PR until we merge #8.

stephengaito commented 8 years ago

Daniel,

While you are considering my latest changes to the "Adding multi secment route parameters (#8)" pull request, I will take your stylistic comments from that pull request and apply then to this pull request.

It will however take me a few days to get time to do this.... quite possibly not until the middle of next week.

I will send you a follow up email when I am done, so you can review the pull request with hopefully fewer comments.

Regards,

Stephen Gaito

On 01/06/16 01:24, Daniel MacDougall wrote:

I'll hold off on reviewing this PR until we merge #8 https://github.com/dmac/spin/pull/8.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dmac/spin/pull/9#issuecomment-222859968, or mute the thread https://github.com/notifications/unsubscribe/ABBztMjkpY3R4Qw7Fp0bEnX-w-whzJaVks5qHNFBgaJpZM4InRcs.

stephengaito commented 8 years ago

Daniel,

I am sorry for the rather long delay.... I am juggling a number of technologies and priorities at the moment (lua and git being only two of quite a number).

However, I have "git cherry-picked" the 4b956f commit onto the end of the adding-multi-segment-route-parameters branch/pull-request (as commit f53c9d9).

I hope that I have now addressed all of your comments/requests.

Let me know if there is anything more that I should do to get this pull-request accepted.

Regards,

Stephen Gaito

On 01/06/16 01:24, Daniel MacDougall wrote:

I'll hold off on reviewing this PR until we merge #8 https://github.com/dmac/spin/pull/8.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dmac/spin/pull/9#issuecomment-222859968, or mute the thread https://github.com/notifications/unsubscribe/ABBztMjkpY3R4Qw7Fp0bEnX-w-whzJaVks5qHNFBgaJpZM4InRcs.