search

dmdorman / hero6e-foundryvtt

MIT License
7 stars 6 forks source link

Combat skill level selection is only using the display and not the name. #1004

Closed tthomsen closed 1 month ago

tthomsen commented 1 month ago

This seems like a bug that was introduced recently. The same issue is happening with weapons master. Here are some screenshots. I can change the Display and that works fine, but I wanted to pass this along.

Combat skill level selection: Display name not working 1

Weapons master selection: weapon skill level selection

Also thanks for getting weapons master and deadly blow working. We used it last night and it worked wonderfully!

aeauseth commented 1 month ago

@tthomsen please attach the HDC file here so I can use it for testing. Yes, I reworked all the powers that allow for weapon selection and I obviously broke something.

Nice to hear Weapon Master and Deadly Blow are working well for you! Always enjoy the positive feedback, most of the feedback we get is related to broken stuff or feature requests.

tthomsen commented 1 month ago

Yeah I hear that. Hacking code can be a thankless job especially when all you hear are complaints. So I appreciate all the hard work everyone is doing. It really makes my life easier as a GM.

This character file should work for all of the issues I submitted except for invisibility. Kwon.zip

aeauseth commented 1 month ago

Kwon has a lot going on. Confirmed the issue you reported. Also issues with equipment compound powers showing in powers tab instead as under the equipment tab. Also the CP costs includes equipment (hidden within powers sum), which it shouldn't. Skills CP calc is off 156 vs 159. Might tweak the layout so the OTHER tab fits into a single line of tabs.

@tthomsen did you know that you can update the HD file for Combat Luck to have it default to ON. Hero Designer defaults to "Do not add to Totals", so it uploads with Combat Luck off. You can change that so it default to ON when uploaded.

tthomsen commented 1 month ago

Yeah, we've been playing this gamer for a while so everyone is OP now. lol Thanks good to know.

aeauseth commented 1 month ago

Fixed. Also included tooltip as I noticed you have duplicate attack names (block for example). You should avoid using duplicate names as it may confuse the automatic attack selection. I recommend adding the word Martial back to your Martial Block, Dodge, etc.

tthomsen commented 1 month ago

I'll have to check the file. I didn't rename those. Probably because I was using the prefabs I purchased from Hero Games, but I'll double check.