search

dmdorman / hero6e-foundryvtt

MIT License
7 stars 6 forks source link

Migration should be automatic and complete on each version #959

Open phBalance opened 2 months ago

phBalance commented 2 months ago

It's too difficult to actually code backwards compatible migrations. We should just "reupload" every character version bump to avoid many problems. It will take longer to migrate but that might also be incentive to fix the upload code to be faster.

To prepare the path we would have to:

  1. Stop the modification of XML values by all code except for the editing code.
  2. Probably have to improve the efficiency of upload code.
  3. Add some migration code to call to invoke upload on all characters and ensure that upload doesn't muck with active effects (it might not anyways) or those may still need explicit migrations when changes happen.
phBalance commented 1 week ago

Added actor migration as a quick partial solution.