dmwm / PHEDEX

CMS data-placement suite
8 stars 18 forks source link

New file replica state is depending on the source node #1110

Open yiiyama opened 6 years ago

yiiyama commented 6 years ago

https://github.com/dmwm/PHEDEX/blob/d2602abdcdf53195c47e7e1e5391d13d6d059e4e/perl_lib/PHEDEX/Infrastructure/FilePump/Agent.pm#L298-L311

New entries to t_xfer_replica are created by FilePump. The state field is set to 0 or 1 depending on the kind of the source node. I think new.kind was supposed to be the kind of the destination node (which would make more sense from the name new too..).

If this is the case, I think we also need to go in to TMDB and set the state of all file replicas on Disk and Buffer nodes to 1. About half of replicas on Disk and almost all of them on Buffer are state 0 at the moment.

Just to make sure, I grepped the entire repository for parts that are dealing with t_xfer_replica.state. The only component that would ever set state to 0 is Stager, which I believe should be handling only MSS nodes.