Request subscription link results in param validation error

dmwm / PHEDEX

CMS data-placement suite

8 stars 18 forks source link

Request subscription link results in param validation error #1119

Open nataliaratnikova opened 5 years ago

nataliaratnikova commented 5 years ago

Here is how to reproduce: Request url: https://cmsweb-testbed.cern.ch/phedex/test/Request::View?request=11021&.submit=Submit

Link to subscriptions url: https://cmsweb-testbed.cern.ch/phedex/test/Data::Subscriptions?reqfilter=11021;node=10;node=4;node=31;node=33;node=1403

The resulting output:

Input parameter for 4 did not pass validation. Please correct the input, or submit a bug report. (use the 'back' button of your browser to return to the form) Error time=2018-11-26 22:47:03 UTC id=691a517e08d9a6f78cf18cf09f46a3b0

nataliaratnikova commented 5 years ago

The same error happens on the production deployment. The reason seems to be a deprecated node:

SQL> select id, name from t_adm_node where id=4; ID NAME

 4 XT1_TW_ASGC_MSS

SQL>

Which name apparently does not pass the validation regex: https://github.com/dmwm/PHEDEX/blob/WEB_4_4_0pre1/perl_lib/PHEDEX/Web/Util.pm#L59

This is not very likely to happen in the production instance. But we may think of a work around if we decide to deprecate multiple sites, e.g. during transition to Rucio.