dmwm / PHEDEX

CMS data-placement suite
8 stars 18 forks source link

Require group selection when creating transfer request #482

Closed ericvaandering closed 10 years ago

ericvaandering commented 10 years ago

Original Savannah ticket 48343 reported by magini on Fri Mar 20 05:09:39 2009.

Hi Ricky,

The T2's and Dataops have decided that we want to add a group assignment label called "Local" which means that it belongs to the local site.

We should remove the "undefined" label which is the current default since it is not clear. I have 2 suggestions for the new default:

1) The default should become "Local" 2) Or we could not have a default and if the user doesn't choose any then you give an error message that says they need to choose a group assignment.

I would be in favor of the latter proposal (2) if it can be implemented easily - since it reminds users that they need to make a group assignment if they didn't know about it.

Thanks. Si

ericvaandering commented 10 years ago

Comment by egeland on Mon Apr 6 04:53:42 2009

Simon,

Do you want to add the "Local" group to SiteDB or should I just keep it in TMDB?

ericvaandering commented 10 years ago

Comment by metson on Mon Apr 6 06:48:55 2009

Hi, Local doesn't really make sense in SiteDB imho (as everybody would be in it, technically). For now keep it in PhEDEx, and if we get tighter coupling of people to sites (e.g. have a site user role) pull it up into SiteDB. How does that sound? Cheers Simon

ericvaandering commented 10 years ago

Comment by egeland on Mon Apr 6 07:36:10 2009

Fine with me, thanks.

'local' group now exists in TMDB, will work on making the group a required field later.

I prefer not to make it the default, in order to force some kind of intelligent decision on what the group will be to the user.

ericvaandering commented 10 years ago

Closed by magini on Wed Jul 13 13:21:32 2011

ericvaandering commented 10 years ago

Comment by magini on Wed Jul 13 13:21:32 2011

Hi,

mandatory group assignment was implemented in PhEDEX 4.0.0

1) User_group is a mandatory parameter in the new transfer request creation form, with no default value

2) added "not null" constraint for user_group in subscriptions schema

Cheers N.