search

dmwm / PHEDEX

CMS data-placement suite
8 stars 18 forks source link

Reorder e-mail alerts #888

Closed ericvaandering closed 10 years ago

ericvaandering commented 10 years ago

Original Savannah ticket 94484 reported by huangch on Thu May 10 01:18:33 2012.

Right now the e-mail alerts that are sent in case of requests for transfer or deletion have first the listing of who else got the e-mail (i.e. contact list), then the request information itself and finally the link to the request.

As these days lots of those requests are made for hundred contacts the contact list is huge and one has to scroll quite some time before getting to the really interesting parts. I'd recommend reversing the order. First should be the link to take immediate action on the request. Then the request data itself and only finally the list of notified people.

ericvaandering commented 10 years ago

Comment by wildish on Fri May 11 05:12:35 2012

Hi Mario,

that sounds reasonable to me. I suggest putting the requestors' comments first, then the link, then the list of people to contact. That way the comments will be harder to miss.

Cheers, Tony.

ericvaandering commented 10 years ago

Comment by mario on Fri May 11 05:13:58 2012

I'd say comments, link, datasets (and size), list of contacts. I assume you planned something of the kind, but just forgot the datasets part :)

ericvaandering commented 10 years ago

Comment by wildish on Fri May 11 05:23:14 2012

Ah yes, datasets. I do tend to forget about them!

your suggestion sounds good to me, and I doubt anyone will object.

Cheers, Tony

ericvaandering commented 10 years ago

Comment by huangch on Fri Jun 22 15:56:28 2012

The content has been re-ordered as follows:

ericvaandering commented 10 years ago

Comment by huangch on Fri Jun 22 16:00:09 2012

Try to make the markup right

ericvaandering commented 10 years ago

Comment by huangch on Fri Jun 22 16:06:48 2012

I give up.

+verbatim+

ericvaandering commented 10 years ago

Comment by cassel on Thu Aug 2 14:09:38 2012

Hi,

I see that this new order was introduced, but applied only to custodial subscriptions... is it intended to test with custodial first, and then apply for all the requests? Deletion requests were not affected as well.

Cheers, Rapolas K.

ericvaandering commented 10 years ago

Comment by huangch on Thu Aug 2 14:57:55 2012

That would be an oversight :-) I'll fix it for deletion request too.

ericvaandering commented 10 years ago

Comment by mario on Wed Aug 8 05:38:16 2012

It's still not the case for transfer requests.

This is what I just got...

Greetings PhEDEx Data Managers,

You may wish to take note of the following new request:

This mail has also been sent to the requestor, the PhEDEx global admins, and the site admins of the relevant sites.

Go to https://cmsweb.cern.ch/phedex/prod/Request::View?request=386160 to handle this request.

Yours truly, PhEDEx Transfer Request Web Form

ericvaandering commented 10 years ago

Comment by wildish on Wed Aug 8 05:45:30 2012

Hi Mario,

patience, please! The next release date is August 14th, so you won't see any change before then. And even then you won't see the fix, because it hasn't been committed yet.

Cheers, Tony.

ericvaandering commented 10 years ago

Comment by mario on Wed Aug 8 06:17:48 2012

Ah, from the discussions I understood that this is already there with the comment from Rapolas that mentioned he seeing it already in place for some things, but not others. So I was reporting that I don't see :) But I guess he was talking about the code in the alert system :)

ericvaandering commented 10 years ago

Comment by huangch on Wed Aug 8 17:34:51 2012

Rapolas,

I checked the code, the same routine is used for all requests. Did you try both, subscription and deletion, and got different formats of email notifications?

ericvaandering commented 10 years ago

Comment by cassel on Thu Aug 9 01:08:23 2012

Hi,

well, I'm getting all the requests, and don't need to try myself. And actually, I see the new order only for high priority custodial replication. If it is normal priority or non custodial, then it is the usual order. So for some reason, high priority custodial requests are ordered different from all the other requests.

Cheers, Rapolas K.

ericvaandering commented 10 years ago

Comment by huangch on Thu Aug 9 18:46:57 2012

Hi, Rapolas,

The production datasvc is at 2_3_10 while the change was tagged at 2_3_11. I guess, those notification emails with new format (order) may not come from production. Let's wait for 2_3_11.

Cheers,

-- Chih-Hao

ericvaandering commented 10 years ago

Comment by mario on Fri Aug 24 01:19:08 2012

Excellent, I've now seen a few of the transfer request e-mails already and it's a ton better. Now I can immediately click on the link and get to it. I'll however open now another ticket as I've got a few more ideas :)

ericvaandering commented 10 years ago

Closed by wildish on Fri Aug 24 05:33:57 2012

ericvaandering commented 10 years ago

Comment by wildish on Fri Aug 24 05:33:57 2012

closing this one quickly, before Mario has any more ideas :-)