dmwm / PHEDEX

CMS data-placement suite
8 stars 18 forks source link

StorageConsistencyCheck script: add -node option instead of -se_name option #948

Closed nikmagini closed 7 years ago

nikmagini commented 10 years ago

Hello,

currently, the PHEDEX/Utilities/StorageConsistencyCheck script accepts "-se_name" as option:

https://github.com/dmwm/PHEDEX/blob/master/Utilities/StorageConsistencyCheck

In some cases (e.g. T1Disk vs T1Buffer/MSS), we have different PhEDEx nodes with the same T_ADM_NODE.SE_NAME in TMDB. To check the two nodes independently, the script should accept the option -node instead.

Thanks, Nicolo'

TonyWildish commented 10 years ago

Alberto, could you take a look at this please?

Thanks. Tony.

alberto-sanchez commented 10 years ago

Sure

Alberto On Nov 18, 2013 10:34 AM, "Tony Wildish" notifications@github.com wrote:

Alberto, could you take a look at this please?

Thanks. Tony.

— Reply to this email directly or view it on GitHubhttps://github.com/dmwm/PHEDEX/issues/948#issuecomment-28713510 .

TonyWildish commented 9 years ago

correcting assignee, for the record, since Alberto provided the fix.

This will go out in 4.1.4, due soon.

nataliaratnikova commented 9 years ago

Hi Tony, Alberto, this script seems to be broken, at least in the current HEAD I get this:

-sh-4.1$ StorageConsistencyCheck -help Global symbol "$se_name" requires explicit package name at /afs/cern.ch/user/r/ratnik/public/SpaceMon/PHEDEX/Utilities/StorageConsistencyCheck line 66. Global symbol "$se_name" requires explicit package name at /afs/cern.ch/user/r/ratnik/public/SpaceMon/PHEDEX/Utilities/StorageConsistencyCheck line 83. Global symbol "$se_name" requires explicit package name at /afs/cern.ch/user/r/ratnik/public/SpaceMon/PHEDEX/Utilities/StorageConsistencyCheck line 88. Global symbol "$se_name" requires explicit package name at /afs/cern.ch/user/r/ratnik/public/SpaceMon/PHEDEX/Utilities/StorageConsistencyCheck line 88. Global symbol "$se_name" requires explicit package name at /afs/cern.ch/user/r/ratnik/public/SpaceMon/PHEDEX/Utilities/StorageConsistencyCheck line 149. Global symbol "$se_name" requires explicit package name at /afs/cern.ch/user/r/ratnik/public/SpaceMon/PHEDEX/Utilities/StorageConsistencyCheck line 149. Global symbol "$tmp" requires explicit package name at /afs/cern.ch/user/r/ratnik/public/SpaceMon/PHEDEX/Utilities/StorageConsistencyCheck line 152. Execution of /afs/cern.ch/user/r/ratnik/public/SpaceMon/PHEDEX/Utilities/StorageConsistencyCheck aborted due to compilation errors.

nataliaratnikova commented 9 years ago

[reopening the ticket] This is reproducible in my public PHEDEX instalaltion on lxplus.cern.ch: . ~ratnik/public/SpaceMon/env.sh StorageConsistencyCheck -h

alberto-sanchez commented 9 years ago

Adding a quick fix. Look like now works!.