dmwm / PHEDEX

CMS data-placement suite
8 stars 18 forks source link

'-limit' option to agents is handled incorrectly in Core/Config/Factory.pm #972

Open TonyWildish opened 9 years ago

TonyWildish commented 9 years ago

The '-limit' option to agents is not handled correctly. For the watchdog, it's supposed to be an array, given as a set of comma-delimited parameters, and that's how it's treated in the createLimits() function in Factory.pm.

However, the FileRemove agent also uses that option, but there it's a simple integer.

The best way to resolve this is to rename the 'limit' option in the watchdog, to avoid the conflict. We could fix it in the code with enough 'if' statements, but that gets messier than I want to deal with.

So, I'll rename the limit option to 'proclimits' in the watchdog agent. That's more descriptive anyway.