dora-team / fourkeys

Platform for monitoring the four key software delivery metrics of software delivery
Apache License 2.0
2.16k stars 591 forks source link

A way to measure Lead time for Change with Squash Option ? #456

Closed kylewin closed 1 year ago

kylewin commented 1 year ago

Dear DORA team,

I know there's a note in README.md for this. It's just that in my case, I have to Squash. Is there a way to make this work with the Squash and Merge option in Github PR ?

Thank you DORA team.

Jake-Mok-Nelson commented 1 year ago

DORA/FourKeys team haven't responded so I'll throw my 2cents in.

I don't think true lead time to change is possible with Squash and merge. Squash and merge removes the initial commit on the feature branch when it's merged into the trunk. The fourkeys solution here relies on that initial commit to calculate the lead time to change metric.

You could use a metric from elsewhere perhaps as the equivalent, e.g. you've created a feature branch and pushed it, if Github could trigger on action of a feature branch being pushed it could record an equivalent metric somewhere, but that wouldn't work with this four keys solution and you'd be rolling a custom solution I think.

kylewin commented 1 year ago

@Jake-Mok-Nelson ja Thank you, sir ! Im closing this.