search

dorienh / jesse

4 stars 0 forks source link

Setting last_x_days=40 #6

Closed dorienh closed 3 years ago

dorienh commented 3 years ago

Three things here:

  1. Allow this to be set in the main engine.

  2. Allow different values, e.g. if I change to 40 I get an error. You should allow big values. May need to dismiss input files that are too short.

  3. After changing to 30 at the top of dataprocess.py, I still get:

X_train Shape (8602, 14, 192), Y_train Shape (8602, 1) X_test Shape (2464, 14, 192), Y_test Shape(2464, 1)

Luckygyana commented 3 years ago

In Preprocess class also there is an argument of last_x_days did you changed that also?

dorienh commented 3 years ago

That's the one I changed:

image

dorienh commented 3 years ago

Oh,

Solved point 3.: the old preprocess.py file was still in my folder and somehow was loaded instead! Strange that that happened, ignoring the filename!

This leaves:

  1. Allow this to be set in the main engine.

  2. Allow different values, e.g. if I change to 40 I get an error. You should allow big values. May need to dismiss input files that are too short. "IndexError: index 120441 is out of bounds for axis 0 with size 120441"

Luckygyana commented 3 years ago

Yes I changed the file for this I will send the file

Luckygyana commented 3 years ago

models.zip

dorienh commented 3 years ago

Thanks, all good!