search

dotkernel / frontend

DotKernel Frontend Application. Based on Zend namespace for branch 1. Based on Laminas and Mezzio for branch 2 and above.
https://v5.dotkernel.net
MIT License
22 stars 5 forks source link

composer.json review #458

Closed bidi47 closed 1 month ago

bidi47 commented 1 month ago

we have dotkernel/dot-session which requires laminas/laminas-session composer.json contains both dotkernel/dot-session and laminas/laminas-session can laminas/laminas-session be removed from composer.json?

alexmerlin commented 1 month ago

You can see when that specific line was introduced by going here and hovering on the commit message.

The line "laminas/laminas-session": "^2.21.0", was added to the requirements a couple of days ago when we implemented CSRF in both DK Admin and Frontend. This feature needs the new CSRF validator, which was introduced in version 2.21.x.

Once we bump laminas-session to ^2.21 in dot-session, we can remove this requirement from both projects. Here's the task list:

bidi47 commented 1 month ago

the topic is resolved in the issues you mentioned i'll close this ticket