search

dotkernel / frontend

DotKernel Frontend Application. Based on Zend namespace for branch 1. Based on Laminas and Mezzio for branch 2 and above.
https://v5.dotkernel.net
MIT License
22 stars 5 forks source link

Temporarily remove `.gitattributes` file to repair CRLF files #497

Closed alexmerlin closed 12 hours ago

alexmerlin commented 1 day ago

The following files still use CRLF instead of LF:

public/fonts/app/Minion-Pro.ttf src/App/assets/fonts/Minion-Pro.ttf src/App/assets/js/components/_avatar.js src/App/assets/js/components/_contact.js src/App/assets/js/components/_profile.js src/App/assets/scss/components/_contact.scss src/App/assets/scss/components/_general.scss src/App/assets/scss/components/_pages.scss src/App/assets/scss/components/_profile.scss src/App/assets/scss/components/_user.scss

Long story short:

I cloned the repo and saw the above files showing up as modified. Thanks to the new .gitattributes file, when we clone a project, all files using CRLF line ending are converted to LF.

alexmerlin commented 1 day ago

Appearently, when the GHA runs and checks out the commit, .gitattributes messes up GitHub's local copy by also modifying these files, causing the action to fail. https://github.com/dotkernel/frontend/actions/runs/11143381645/job/30968350463

I tried removing from .gitattributes the line that is reposnsible with the conversion, by it did not seem to work. https://github.com/dotkernel/frontend/actions/runs/11143381645/job/30968496941