Update .NET MAUI app to .NET 9

dotnet / eShop

A reference .NET application implementing an eCommerce site

MIT License

6.46k stars 1.94k forks source link

Update .NET MAUI app to .NET 9 #581

Closed jamesmontemagno closed 3 weeks ago

jamesmontemagno commented 1 month ago

PR Classification

Code cleanup and upgrade to .NET 9.0.

PR Summary

This pull request updates the project to target .NET 9.0, includes code cleanup, and updates package references.

App.xaml.cs: Overridden CreateWindow method to return a new Window instance with AppShell and updated SetStatusBar method.
ClientApp.csproj and HybridApp.csproj: Target .NET 9.0 and updated package references.
Basket.cs: Improved protobuf parsing by handling end group tags.
DialogService.cs: Updated to use AppShell.Current.DisplayAlert instead of Application.Current.MainPage.DisplayAlert.
SettingsViewModel.cs: Made TitleUseAzureServices property non-static.

jamesmontemagno commented 1 month ago

@jfversluis can you pull this and take a look as to why teh fontawesome icons aren't loading....

jfversluis commented 4 weeks ago

@jfversluis can you pull this and take a look as to why teh fontawesome icons aren't loading....

Tested on iOS, macOS and Android and it shows the icons there, so maybe just a fluke?

jfversluis commented 4 weeks ago

I do see a couple of

Microsoft.Maui.Controls.BindableObject: Warning: Cannot convert 6 to type 'System.Int32'

and one

Microsoft.Maui.Controls.BindableObject: Warning: Value is an invalid value for ColumnSpan

In the debug output, but can't really pinpoint where its coming from. Does that ring a bell?

jamesmontemagno commented 3 weeks ago

was able to fix up the column span thing... nto srue about the "6" that is weird

It has to be somethign on the login page...

if i delete

 <Button
      Grid.Row="2"
      Grid.Column="0"
      Margin="8"
      BackgroundColor="Black"
      Command="{Binding SignInCommand}"
      CornerRadius="16"
      Text="Login"
      TextColor="White" />

the warnings go away