layomia
commented
3 years ago The only reference to the constructor is this LOC from the following snippet:
if (!_classes.TryGetValue(type, out JsonClassInfo? result))
{
if (JsonHelpers.DisableJsonSerializerDynamicFallback)
{
throw new NotSupportedException($"Metadata for type {type} not provided to serializer - will not go down reflection-based code path.");
}
else
{
result = _classes.GetOrAdd(type, new JsonClassInfo(type, this));
}
}The JsonHelpers.DisableJsonSerializerDynamicFallback boolean above is controlled by a linker feature switch (which is active in this repro). I mention this in case there is an issue with ILLinker only trimming source in the else branch, rather than also trimming all code that it references.
mateoatr
eerhardt
sbomer
ericstj
The vertex in question,
"Method:System.Void System.Text.Json.Serialization.Metadata.JsonClassInfo::.ctor(System.Type,System.Text.Json.JsonSerializerOptions)", is not used anywhere in the app. There's also no descriptor file that roots this ctor.I've attached the linker dependency zip.
Repro steps:
"https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-experimental/nuget/v3/index.json"as a NuGet feed, to get the updated System.Text.Json.dll and source generator.dotnet publish -c Releaseillinkanalyzer -r "Method:System.Void System.Text.Json.Serialization.Metadata.JsonClassInfo::.ctor(System.Type,System.Text.Json.JsonSerializerOptions)" linker-dependencies.xml.gzYou'll find that the ctor is not a dependency of any other vertex, yet it is preserved after trimming.
Here's the linker command:
cc @sbomer @agocke @mateoatr @vitek-karas @eerhardt
linker-dependencies.xml.gz