dotnet / linker

389 stars 126 forks source link

Specify all source-built dependencies and ensure they are regularly updated #3007

Closed mmitche closed 1 year ago

mmitche commented 2 years ago

Overview

Source-build works today by building a repository, gathering the versions of the outputs, and creating a property file with those versions. This property file is then fed to downstream repositories, which import it after their eng/Versions.props. The resulting behavior is that the downstream repo overrides all dependency versions specified in eng/Versions.props with the versions built from source. This behavior is not the same as the Maestro dependency-flow based approach. Maestro only updates properties for dependencies that are specified in eng/Version.Details.xml.

This causes the following difference: Say that dotnet/aspnetcore has a Microsoft.Net.Compilers.Toolset dependency. It codes a property for that dependency's version in eng/Versions.props as MicrosoftNetCompilersToolsetVersion, with an older version of the package.

This difference tends to cause build breaks in source-build. The version bump may be significant and require repo reaction. This is not ideal and not sustainable.

One option would be to only override those versions that are specified in eng/Version.Details.xml. This would more closely align the source-build and current official builds. The huge downside is that this will cause an explosion of ref packs. And in some cases, we would be building against old versions but actually executing against newer ones. Non-ideal.

In summary, the goals are:

Work Required

This work is dependent on https://github.com/dotnet/source-build/issues/2982.

In this repo, do the following

mmitche commented 2 years ago

This is .NET 8 work

mmitche commented 1 year ago

Closing as completed as part of the source-build sustainability (PVP and prebuilt detection) work