search

dotnet / linker

387 stars 134 forks source link

Make external cecil projects build in isolation #3192

Closed ViktorHofer closed 1 year ago

ViktorHofer commented 1 year ago

Updates ProjectReferences that point to the two referenced Mono.Cecil projects in order not flow the globally set RepoRoot and VersionsPropsPath properties. That guarantees that these projects are always built deterministically (VS vs dotnet build vs build.cmd).

For more context, see the offline mail conversation between @vitek-karas, @sbomer and me.

ViktorHofer commented 1 year ago

Converting to draft as builds are failing. Taking a look.

tlakollo commented 1 year ago

I think this is not needed anymore given that dotnet/linker no longer produces the illink package and that runtime uses a different way to obtain cecil. In any case, if this is needed probably needs to be done in runtime instead.