search

dotnet / linker

387 stars 134 forks source link

[main] Update dependencies from dotnet/arcade #3198

Closed dotnet-maestro[bot] closed 1 year ago

dotnet-maestro[bot] commented 1 year ago

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

akoeplinger commented 1 year ago

Weird, tests are failing with

Assert.Contains() Failure Not found: (filter expression) In value: List<ValueTuple<MessageImportance, String>> [(High, Fatal error in IL Linker), (High, Unhandled exception. System.IO.FileNotFoundException: Could not load file or assembly 'Mono.Cecil, Version=0.11.4.0, Culture=neutral, PublicKeyToken=50cebf1cceb9d05e'. The system cannot find the file specified.), (High, File name: 'Mono.Cecil, Version=0.11.4.0, Culture=neutral, PublicKeyToken=50cebf1cceb9d05e'), (High, at Mono.Linker.Driver.Dispose()), (High, at Mono.Linker.Driver.Main(String[] args) in /_/src/linker/Linker/Driver.cs:line 68)]

tlakollo commented 1 year ago

See https://github.com/dotnet/cecil/pull/66, after this change cecil is broken inside dotnet/linker given that is not able to override a package called Mono.Cecil since with the new packaging logic only Microsoft.DotNet.Cecil exists. Given that the darc flow from arcade is now disabled for main and the main branch of dotnet/linker is archived I will just close this PR and not merge the update.