dotnet / linker

387 stars 134 forks source link

Port dotnet/runtime#82197 to dotnet/linker #3203

Closed jtschuster closed 1 year ago

jtschuster commented 1 year ago

Original PR: dotnet/runtime#82197

Customer Impact:

Addresses the issue in https://github.com/dotnet/runtime/issues/81746. The linker can produce invalid IL when a user assembly is not trimmed, but the framework is trimmed (as is common in wasm and blazor). If a user code implements a static abstract interface method but the interface method is never used, the trimmer removes the interface method from the interface, but leaves the (now dangling) reference to it in the overriding method.

This fixes the issue by making sure all methods referenced in the .overrides metadata of method X are marked if method X is in a 'copy' assembly (an untrimmed assembly), where previously we would postpone marking the .overrides if the base was static abstract.

Testing:

The existing tests in the repo guard against any regressions, and a new test case demonstrates the change in behavior.

Risk:

There is very little risk. The change in behavior is very small, and the situations there is a change in behavior seem to be uncommon.