doublesecretagency / craft-cpcss

Control Panel CSS plugin for Craft CMS
MIT License
117 stars 8 forks source link

feat: add `ecs` & `phpstan` code analysis #23

Open khalwat opened 6 months ago

khalwat commented 6 months ago

Add ecs & phpstan code analysis

I also ran both ecs and phpstan, which cleaned up the code, and I manually fixed one error phpstan pointed out.

You can manually run either ecs or phpstan in local dev, and they will also automatically be run:

When someone does a PR, it'll look like this for them:

Screenshot 2024-03-11 at 10 30 55 PM

...and then once it has passed (or failed) it'll look like this:

Screenshot 2024-03-11 at 10 31 25 PM
khalwat commented 6 months ago

I did this only for the Craft 5 version of the plugin. If you want to backport it to Craft 4, it's the exact same everything for Craft 4.