Open khalwat opened 6 months ago
Add ecs & phpstan code analysis
ecs
phpstan
I also ran both ecs and phpstan, which cleaned up the code, and I manually fixed one error phpstan pointed out.
You can manually run either ecs or phpstan in local dev, and they will also automatically be run:
v3-dev
When someone does a PR, it'll look like this for them:
...and then once it has passed (or failed) it'll look like this:
I did this only for the Craft 5 version of the plugin. If you want to backport it to Craft 4, it's the exact same everything for Craft 4.
Add
ecs
&phpstan
code analysisI also ran both
ecs
andphpstan
, which cleaned up the code, and I manually fixed one errorphpstan
pointed out.You can manually run either
ecs
orphpstan
in local dev, and they will also automatically be run:v3-dev
branchWhen someone does a PR, it'll look like this for them:
...and then once it has passed (or failed) it'll look like this: