doubtfire-lms / doubtfire-web

Angular web application for the Doubtfire front-end

GNU Affero General Public License v3.0

45 stars 332 forks source link

fix: remove the incorrect option from for scrollIntoView() #824

Closed ublefo closed 4 months ago

ublefo commented 5 months ago

Description

There are a lot of errors in the javascript console in Firefox when clicking on the tasks in the task list:

Element.scrollIntoView: 'top' (value of 'block' member of ScrollIntoViewOptions) is not a valid value for enumeration ScrollLogicalPosition.

top is not a valid option for scrollIntoView(), start is the default so there is no need to define it explicitly.

https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollIntoView

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

The aforementioned errors are no longer present in the javascript console on Firefox when switching tasks.

Testing Checklist:

[x] Tested in latest Chrome
[ ] Tested in latest Safari
[x] Tested in latest Firefox

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] My changes generate no new warnings

HarshitaShroff commented 4 months ago

Set up Astra website