doubtfire-lms / doubtfire-web

Angular web application for the Doubtfire front-end

GNU Affero General Public License v3.0

45 stars 333 forks source link

enhance/allow-live-pdf-search #849

Closed keraan closed 5 months ago

keraan commented 5 months ago

Description

This pull request implements a live PDF search feature. The search results update dynamically as the user types.

Type of change

[x] New feature (non-breaking change which adds functionality)

Changes

Added ngModelChange event binding to trigger the searchPdf function on input change
Removed the form's ngSubmit directive to avoid submission on enter key press

How Has This Been Tested?

Tested in browser

Testing Checklist:

[x] Tested in latest Chrome
[ ] Tested in latest Safari
[ ] Tested in latest Firefox

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have requested a review from @macite and @jakerenzella on the Pull Request

jakerenzella commented 5 months ago

No notes! Good stuff.