doubtfire-lms / doubtfire-web

Angular web application for the Doubtfire front-end
GNU Affero General Public License v3.0
45 stars 332 forks source link

fix: task list scrolling #855

Closed Bahnschrift closed 3 months ago

Bahnschrift commented 3 months ago

Description

Scrolling on staff task lists (e.g. in the inbox and explorer screens) was a bit broken. On firefox in particular, scrolling too far would cause box to start jumping up and down. This seems to be a result of the <mat-list> containing the elements having 1 pixel of padding: https://v17.material.angular.io/cdk/scrolling/overview#elements-with-parent-tag-requirements.

Should be fixed by manually setting 0 margin and padding.

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Tested on Firefox and Chromium. Afaik the issue was only obviously present on Chromium before, and with this change it isn't present on either. No noticeable visual changes.

Testing Checklist:

Checklist:

Bahnschrift commented 3 months ago

Tested on chromium and firefox. Unfortunately can't test Safari, but if it was working there before, it should still be working now.