doubtfire-lms / doubtfire-web

Angular web application for the Doubtfire front-end
GNU Affero General Public License v3.0
45 stars 332 forks source link

refactor(timeout): Migrate Timeout Component to Angular 17 and TypeScript #868

Closed sylvia0929 closed 1 month ago

sylvia0929 commented 1 month ago

Overview

This PR migrates the timeout component from AngularJS and CoffeeScript to Angular 17 and TypeScript.

Changes Made

Migration Details

Screenshots

Additional Notes

Thank you!

AusBruce commented 1 month ago

The migration of the timeout component from AngularJS and CoffeeScript to Angular 17 and TypeScript is well-executed. The component benefits from modern Angular features, improved performance, and enhanced maintainability. Great job! one more thing is for the description, can you also please upload the screenshot of what before and after migration the component look like?

AusBruce commented 1 month ago

File Structure and Organization:

The files have been correctly placed in the src/app/errors/states/timeout/ directory, following a logical structure. The separation of concerns is clear, with HTML and TypeScript files separated.

Functionality:

The component retains its original functionality and user interactions. No bugs or regressions were observed during testing. The retry and home options work as expected.

jakerenzella commented 1 month ago

Is this PR intended to be on a fork? @macite

AusBruce commented 1 month ago

Is this PR intended to be on a fork? @macite

it should be on a fork repo, tothtech/doubtfire-web.

tinahoa commented 3 weeks ago

Hi Shen,

The HTML structure within the timeout component looks good overall, but there is an unnecessary and unused block of code that should be removed for clarity and maintainability.

Specifically, the placeholder comment within the first tag is redundant and not being utilized.

Screenshot 2024-08-23 at 10 10 21 PM

I recommend deleting this block to avoid confusion and to keep the code clean.