Open b0ink opened 1 month ago
Hey, Eliya looks like the migration is done really well in terms of both code and design. The new component looks modern and keeps the original functionality intact while improving the code structure and user interface.
Original confirmation-modal migration PR: https://github.com/doubtfire-lms/doubtfire-web/pull/846
Created a new branch from the development branch and added @s223749059's commits before making additional changes of replacing the bootstrap html with material components and a couple fixes.
Description
Migrates the
confirmation-modal
component from CoffeeScript to TypeScript. This component is used in the unit-tutorials-list, unit-task-editor, and portfolio-review-step components. The confirmation modal is used to display a dialog with a title, message, where users can either click cancel to dismiss the dialog, or click confirm which will run the callback function originally passed when opening the modal.Type of change
How Has This Been Tested?
aconvenor
oraadmin
Before:
After:
Testing Checklist:
Checklist: